Ben Howell

Results 19 comments of Ben Howell

Possibly will be improved by the fix to #24707

It looks like this is probably a regression from PR #24562. In useMenu.tsx, previously it was spreading `...props`, which let the prop values override the default value for `openOnHover`. However,...

It looks like this is caused by the fact that icons from `@fluentui/react-icons` don't currently forward refs to their underlying DOM element, which is a requirement for v9 Tooltip. (Or...

After talking to Design, we decided that SwitchField should always use the field's label, and not provide access to the underlying Switch's label. This is the currently implemented behavior, although...

@ling1726 @bsunderhus I've added a cypress e2e test.

Need to follow up with design to check if this applies to other Input-like components such as SpinButton, Combobox, Dropdown, Select, Textarea.

Closing in favor of #24394

This should be fixable by allowing any prop that starts with `data-`, e.g.: ``` Record ``` However, it looks like this requires TypeScript 4.4+ to work: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-4.html#symbol-and-template-string-pattern-index-signatures . Our repo...

It looks like it's not possible to add support for this for clients that are on TypeScript 4.4 yet. Our TypeScript minbar is 3.9, and adding a template literal type...

@ecraig12345 to follow up on what partner requirements are