fluentui icon indicating copy to clipboard operation
fluentui copied to clipboard

Add type downleveling (typesVersions)

Open ecraig12345 opened this issue 3 years ago • 13 comments

A "good enough" initial solution to ensuring TS 3.9 compatibility is just banning type constructs introduced in 4.0+ (see #18440), but we may want to add actual downleveling in the future. downlevel-dts could help. A bit more discussion on #16101.

ecraig12345 avatar Jun 03 '21 16:06 ecraig12345

@ecraig12345 is it possible you prioritize this? We have already met this problem, for example, in #19281.

layershifter avatar Aug 06 '21 08:08 layershifter

@layershifter I'm not sure if I'll have time to work on this along with other things I'm already supposed to be doing. I also wasn't aware that we had a TS minbar < 4 for converged.

ecraig12345 avatar Aug 06 '21 17:08 ecraig12345

It looks like downlevel-dts is still at the level of a side project at best, though it does support named tuples. A downside is that unless we switched to only shipping a single rollup file, adding a downleveled version of every .d.ts would bloat the package.

The easiest approach might be to add a basic test with TS 3.9 as described in #18440.

ecraig12345 avatar Aug 06 '21 17:08 ecraig12345

@ecraig12345 to follow up on what partner requirements are

behowell avatar Aug 12 '21 16:08 behowell

based on recent convo regarding BC for popover, I'll explore this during FHL

Hotell avatar Mar 16 '22 16:03 Hotell

I have workable tooling that includes tests automation. Will need to polish that. After that I'll start implementing it for v9

https://github.com/Hotell/blogposts/pull/73#issuecomment-1078915393

Hotell avatar Mar 29 '22 15:03 Hotell

related: https://github.com/microsoft/fluentui/issues/19537

Hotell avatar Apr 04 '22 08:04 Hotell

Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

msft-fluent-ui-bot avatar Oct 01 '22 10:10 msft-fluent-ui-bot

this is planned for Q3 22/23

Hotell avatar Nov 02 '22 12:11 Hotell

Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

msft-fluent-ui-bot avatar May 01 '23 13:05 msft-fluent-ui-bot

Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.