Brian Behlendorf

Results 234 comments of Brian Behlendorf

@wci @allanjude sorry about the delay in getting back to this. Thanks for addressing my initial feedback. I should be able to further dig in to the PR this week...

OK, #11514 #11515 #11516 #11517 #11518 have all been merged and can be dropped from this PR with a rebase.

~@wci~ @wca when you get a chance to rebase this that would be great.

> Thanks for the info, I never handled this previously. The libzfs.abi delta seems pretty big, is that normal? I'm still pretty new to it myself. But from what I've...

@wca would you mind rebasing this again on the latest master. There's a minor conflicts to resolve and you'll need to generate a new `libzfs.abi` file, the recent "compatibility" feature...

@wca it looks like there's still at least one path in the force export code which needs to be updated. This was caught by the CI http://build.zfsonlinux.org/builders/CentOS%208%20x86_64%20%28TEST%29/builds/2902/steps/shell_4/logs/console

@wca it looks to me like we're now just seeing a failure in the `checkpoint_lun_expsz` test case. I'll see if I can reproduce this to debug it, it looks like...

Thanks for rebasing this. The failures look unrelated to me, I've gone ahead and resubmitted the build on those bots to see if it's reproducible. If you get a chance...

@allanjude it's a recently added test case, so we have less mileage on it, but I don't recall seeing it fail in the CI before. See 88a4833039b4a3f08139c5b69a2300424fddfd0f.

I'd love to see this work completed. The next steps needed to make that happen would be to address the outstanding review feedback, rebase the PR on the latest master...