Brian Behlendorf
Brian Behlendorf
Interestingly this change appears to cause the following two test case failures. Before this can be merged that will need to be understood and sorted out, http://build.zfsonlinux.org/builders/CentOS%208%20x86_64%20%28TEST%29/builds/9178/steps/shell_4/logs/summary ``` FAIL checksum/filetest_002_pos...
> I have no idea why checksum error is ignored if ZIO_FLAG_SPECULATIVE is set. Checksum errors aren't reported for prefetch I/O since it's possible the prefetch read might fail if...
Can you please squash these commits, rebase this branch on the current master branch, and force update the PR. That should help with some of the failed CI bots.
@Finix1979 if you can rebase this one more time and resolve the outstanding checkstyle warnings this is good to go. https://github.com/openzfs/zfs/runs/8044573481?check_suite_focus=true ``` Run make -j$(nproc) --no-print-directory --silent checkstyle no errors...
@jelinekr I'm surprised this hasn't come up before. Right now there's no way to disable `.zfs` snapshot automounting but I definitely agree there should be. For the moment you'll need...
Good question, I suppose it will need to fail with a reasonable errno to ensure snapdir can be safely enabled again if desired.
This issue was addressed in master by adding support for `zfs allow` in commit f74b821a6696fef9e9953aae05941e99bf83800e. Enforcement is now done through delegations which is consistent with the other OpenZFS platforms. The...
Reopening. Thanks for revisiting this, we should provide a mechanism to at least disable the snapshot directories.
@GregorKopka since most issues are marked as defect and it gives us a chance to revisit them. This is in fact still an issue until the ZAP code is extended...
> `zfs_log_write` implementation v1: This has been implemented in the updated PR. For O_DIRECT writes WR_INDIRECT log records are now always used and the block pointer is stored in the...