Benedikt Ehinger comments

Results 227 comments of


                                            Benedikt Ehinger

Contributor Issue

@all-contributors please add @palday code,infra

Contributor Issue

@all-contributors please add @kleinschmidt doc

Contributor Issue

@all-contributors please add @ssaket for bug

Contributor Issue

@all-contributors please add @suddha-bpn bug

why !isnothing(basisfunction) here?

a) the following line of code is never reached and can be removed b) UnfoldLinearMixedModelContinuousTime doesnt currently work (but there are tests)

FIR with duration

please check, unclear if compatible with the new fastpath `time_expand_allBasesSameCols` in designmatrix.jl

I implemented spline as a starter. => See Pluto notebooks /docs/nb_timesplines.jl and ./docs/nb_timesplines_dev.jl What I didnt really think about, is that we commonly want to move the temporal predictors from...

implement time-splines

``` begin gd = groupby(res,[:basisname,:channel,:group,:coefname]) a = combine(gd) do d return undoBasis(d,m) end a end function undoBasis(d,m) bname = unique(d.basisname) # the current coefficient basename @assert(length(bname)==1) @assert(length(unique(d.channel))==1) bnames = unique(Unfold.get_basis_name(m))...

differentiate between sparse and non sparse basisfunctions

second problem is solved. But not yet through all instances of basisfunction.times, e.g. tutorials are still missing

hrf

also this in case I want to rewrite the HRF function https://github.com/TimVanMourik/OpenFmriAnalysis/blob/7786ebc7a19b3480022b3e347bc1348b38256ca1/Core/private/tvm_sampleHrf.m