beguene
beguene
Everything looks fine to me There is only 1 transaction initiated by the wallet owner https://explorer.stacks.co/txid/0x065a96f858fc061eb82ab5287c9ca1978653a83d885f86a2460cd4de1efba4b5?chain=mainnet with nonce = 0 The next nonce should be 1 as returned also by...
I could not really reproduce the 'infinite' but it can be quite slow sometimes even on chrome. I am working on 2 code fixes which significantly reduce this time and...
@kyranjamie yes this will address #1877 too
@andresgalante Regarding "Add metrics to understand the impact of that change", there is already a metric added by @kyranjamie before, which englobes the decrypt function and the call to Gaia....
Moving it to backlog as we need to check the analytics. This could be picked up again in a few weeks.
@markmhx you need to check 'start_unlock' and 'complete_unlock' 'complete_unlock' has a 'duration' properties in ms You should also check 'start_unlock that is not followed by a 'complete_unlock'. Those are users...
@markmhx I think we should still keep the 'Learn more'. It's currently linking to https://docs.hiro.so/build-apps/message-signing. Shall we link to the [blog post](https://www.hiro.so/blog/how-arbitrary-message-signing-works-in-the-hiro-wallet) instead ?
For QA: Only regression tests are needed here.
@andresgalante Not sure about the next steps. In this PR I fixed the unit tests errors but I did not touch the profile signing issue maybe @pradel Can give more...
This is partially addressed. To be picked up later if some users still face this issue.