extension icon indicating copy to clipboard operation
extension copied to clipboard

Published 20 hours ago • verified publisher icon leather-wallet

Address changes to stacks.js packages

Open fbwoolf opened this issue 2 years ago • 14 comments

https://discord.com/channels/621759717756370964/803293319328170024/948604001174323241

as of stacks.js >3.3.0 the bundling (main fields) is a bit different, for the same behavior as previously you will likely want to add a resolve.alias to the webpack config as seen here: https://github.com/janniks/stacks-wallet-web/blob/fea34ecfa667518ea9eecdf3b8161aa8e3fad1e3/webpack/webpack.config.base.js#L72-L82 (only for the relevant updated packages)

another diff for when upgrading all stacks.js packages to latest: https://github.com/hirosystems/stacks-wallet-web/compare/dev...janniks:add-esm-alias

fbwoolf avatar Mar 02 '22 19:03 fbwoolf

This needs to be addressed when we update to 3.3.0 stacks.js packages. We are currently using 3.0.0.

fbwoolf avatar Mar 02 '22 19:03 fbwoolf

For QA: Only regression tests are needed here.

beguene avatar Mar 28 '22 10:03 beguene

.btc names still do not work with the latest version of the app https://sigle-git-feature-stacks-wallet-extension-sigle.vercel.app/

Ran a test with a regular ID it works fine. Then ran a test with my .btc username and it wont allow you into the app

VIDEO of the issue https://somup.com/c3evqbOVTC

timstackblock avatar Mar 31 '22 15:03 timstackblock

@timstackblock is any error showing up in particular for the app in the developer console?

markmhendrickson avatar Apr 01 '22 12:04 markmhendrickson

I was able to authenticate with my own .btc username.

image

markmhendrickson avatar Apr 01 '22 12:04 markmhendrickson

Will retest upon having https://github.com/hirosystems/stacks-wallet-web/issues/2283 issue fixed

Eshwari007 avatar Apr 06 '22 15:04 Eshwari007

Waiting for the test app to update stackjs to be QAed

andresgalante avatar Apr 18 '22 14:04 andresgalante

@janniks Kindly advise if the stack.js has been updated and its good to go for another round of testing. Thx

Eshwari007 avatar Apr 20 '22 13:04 Eshwari007

I released stacks.js + connect, will now create a wallet-web PR that updates to the latest versions...

janniks avatar Apr 20 '22 15:04 janniks

Thanks @janniks, for testing purposes, I updated the staging Sigle app https://sigle-git-feature-stacks-wallet-extension-sigle.vercel.app/ with the latest stacks.js + connect too.

pradel avatar Apr 20 '22 16:04 pradel

I released stacks.js + connect, will now create a wallet-web PR that updates to the latest versions...

@janniks Do ping me when I can test the new stacks.js changes on web wallet extension.Thanks

Eshwari007 avatar Apr 22 '22 21:04 Eshwari007

https://github.com/hirosystems/stacks-wallet-web/pull/2333 updates to current stacks.js (4.0.0)

janniks avatar Apr 22 '22 21:04 janniks

#2333 updates to current stacks.js (4.0.0)

@janniks Test passed with the web extension above ,singing in to https://sigle-git-feature-stacks-wallet-extension-sigle.vercel.app/

Eshwari007 avatar Apr 25 '22 14:04 Eshwari007

Tested the fix with https://app.stackswap.org/swap as well, its working well!!

Eshwari007 avatar Apr 25 '22 20:04 Eshwari007