J. Nick Koston

Results 1005 comments of J. Nick Koston

> Ok thanks, I didn't know you could add it to **init**.py like that. > > Will this method in binary_sensor.py override the one in **init**.py? Otherwise everyone will be...

Please update proposed change description

Saw this in testing but I didn't have the latest version ``` 2022-08-10 15:11:55.668 ERROR (MainThread) [homeassistant.components.bluetooth] Error in bluetooth callback Traceback (most recent call last): File "/Users/bdraco/home-assistant/homeassistant/components/bluetooth/__init__.py", line 489,...

> Havent seen that myself, but I just bumped the parser to always return False in needs_poll if parser.pending (pending is True until it has definitely pased something). It took...

Will try to give you some more feedback tomorrow. I'm way behind as I've had two A/C units fail this week @ home which is not good in a Texas...

I won't have time to do a proper review until tomorrow, but in the mean time I'll give feedback on the things I know will require refactoring

> @bdraco I refactored the HEV sensors into a single binary sensor with extra state attributes which provides a much better user experience (IMO). At a glance, you can see...

https://www.usb.org/sites/default/files/327216.pdf