core icon indicating copy to clipboard operation
core copied to clipboard

Simplify switchbot config flow

Open bdraco opened this issue 1 year ago • 1 comments

Proposed change

  • Do not ask for a password if the device does not need one

  • Confirm discovery right away if no more information is needed

  • Generate the name from the friendly device type and short address

  • Allow changing the name by adjusting the config entry title

  • Confirm only the device if only one device is found

Upstream change to provide the friendly names : https://github.com/Danielhiversen/pySwitchbot/compare/0.17.3...0.18.4

Screen Shot 2022-08-04 at 4 54 23 PM Screen Shot 2022-08-04 at 4 54 20 PM Screen Shot 2022-08-04 at 4 30 11 PM Screen Shot 2022-08-04 at 4 30 06 PM Screen Shot 2022-08-04 at 4 24 58 PM Screen Shot 2022-08-04 at 4 24 39 PM Screen Shot 2022-08-04 at 4 24 28 PM Screen Shot 2022-08-04 at 4 24 16 PM Screen Shot 2022-08-04 at 4 24 10 PM Screen Shot 2022-08-04 at 4 24 07 PM

Type of change

  • [x] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [x] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #76225
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • [x] The code change is tested and works locally.
  • [ ] Local tests pass. Your PR cannot be merged unless tests pass
  • [ ] There is no commented out code in this PR.
  • [ ] I have followed the development checklist
  • [ ] The code has been formatted using Black (black --fast homeassistant tests)
  • [x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • [ ] No score or internal
  • [ ] 🥈 Silver
  • [ ] 🥇 Gold
  • [ ] 🏆 Platinum

To help with the load of incoming pull requests:

bdraco avatar Aug 05 '22 02:08 bdraco

Hey there @danielhiversen, @renierm26, @murtas, @eloston, mind taking a look at this pull request as it has been labeled with an integration (switchbot) you are listed as a code owner for? Thanks! (message by CodeOwnersMention)

Thanks

bdraco avatar Aug 10 '22 16:08 bdraco