J. Nick Koston

Results 2087 comments of J. Nick Koston

The integration needs to be converted to a config flow before new options can be added per ADR0007 (https://github.com/home-assistant/architecture/blob/master/adr/0007-integration-config-yaml-structure.md) I've opened a PR to convert it to a config flow....

https://github.com/home-assistant/core/pull/50429 has been merged, which now sets the ground work for additional changes to be built on top of it.

> For better backward compatibility, an alternative approach could be to introduce a `timeout_seconds` parameter in the `DockerContainer.log()` function, defaulting to 300 seconds. I think this is a better approach...

We shouldn't use ClientTimeout directly as an external input since it's an aiohttp object that may change in the future. The fact that aiohttp is used internally is an implementation...

I didn't make a helper because Cython would end up ref counting the Mark object being passed around in the helper.. It might not make much difference though. Will test

Still a nice speed up even with the helper. Note that 3.1 got a bit faster already since I opened this PR ### With Cython 3.1 `main` (new baseline) ```...

Pushed another one that a bit different. Single call point but it does have a bit more maintenance burden. 688ebe766c4c9e4cb4e3d79aa9cfc5fbb9c0f097 ``` Benchmark Results ┏━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━┓ ┃ Benchmark ┃ Time (best) ┃...

I was able to find the underlying issue which turned out to be broken firmware on a camera without this change. I'll leave it here in case something things its...

I ended up writing a cookie parser in https://github.com/aio-libs/aiohttp/pull/11106#issuecomment-2927246152 but I'm too afraid to move it forward as I'm not sure what will break as currently we need bug for...

I refactored a bit. I looked at all the usage of `fnv1_hash(App.get_compilation_time_ref())` Currently build time is always regenerated now. Need to do careful analysis of all the call sites to...