Nmap tracker keep rediscovering excluded hosts with DHCP

[petterreinholdtsen]

When enabling the nmap tracker on a network using DHCP, the excluded host MAC addresses are "rediscovered" when they change IP address. This make the component less useful. Instead of excluding IP addresses, it make more sense to exclude the MAC addresses of devices that should be ignored. It do not really make sense that the nmap tracker is set up to discover MAC addresses, but must be told to ignore IP addresses.

Would you accept a patch to extend the exclude mechanism to look for entries with colon in them and treat them as MAC addresses to ignore?

[stale[bot]]

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue now has been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

[petterreinholdtsen]

Well, the question is still not answered and still valid, so the issue is not "stale". Perhaps someone can have a look and provide some feedback?

[stale[bot]]

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue now has been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

[petterreinholdtsen]

Well, the question is still not answered and still valid, so the issue is not "stale". Perhaps someone can have a look and provide some feedback?

[stale[bot]]

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue now has been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

[petterreinholdtsen]

As can be seen on https://github.com/home-assistant/core/blob/master/homeassistant/components/nmap_tracker/device_tracker.py , there is still no way to exclude specific MAC addresses with the nmap tracker, so this issue is still not solved.

[stale[bot]]

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue now has been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

[petterreinholdtsen]

According to https://github.com/home-assistant/core/blob/master/homeassistant/components/nmap_tracker/device_tracker.py, there is still no way to exclude specific MAC addresses with the nmap tracker, so this issue is still not solved.

-- Happy hacking Petter Reinholdtsen

[github-actions[bot]]

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

[petterreinholdtsen]

There is still no way to exclude specific MAC addresses with the nmap tracker, so this issue is still not solved.

-- Happy hacking Petter Reinholdtsen

[rocket4321]

As a fellow HA user, I try to help were I can, so take a look and let me know if this resolves your issue. If so, I'll submit a PR. Let me know either way please.

https://github.com/rocket4321/nmap_tracker

[petterreinholdtsen]

The exclude_mac code look like it should work. :)

[github-actions[bot]]

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

[petterreinholdtsen]

@rocket4321 Did you have any luck with submitting a bull request? The master branch code still have no way to exclude MAC addresses.

[bdraco]

The integration needs to be converted to a config flow before new options can be added per ADR0007 (https://github.com/home-assistant/architecture/blob/master/adr/0007-integration-config-yaml-structure.md)

I've opened a PR to convert it to a config flow. https://github.com/home-assistant/core/pull/50429

This opens the door to add additional options once it moves forward.

[bdraco]

https://github.com/home-assistant/core/pull/50429 has been merged, which now sets the ground work for additional changes to be built on top of it.

[petterreinholdtsen]

Great. Perhaps the change from @rocket4321 in https://github.com/rocket4321/nmap_tracker can be ported to this new setup and integrated into the official package.

[github-actions[bot]]

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

[petterreinholdtsen]

As far as I can tell from https://github.com/home-assistant/core/blob/master/homeassistant/components/nmap_tracker/device_tracker.py the change to exclude mac addresses is still not merged.

[petterreinholdtsen]

The fix from @rocket4321 looked good to me, but I do not really know the inner workings on home assistant. Is it hard to add a configuration option?

[github-actions[bot]]

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

[petterreinholdtsen]

Sadly it is still a problem.

[lambchop01]

Also looking to do this. still no solution?

[rocket4321]

No, a solution very much exists. One that has been working well for years. Coded , uploaded, but curtly rejected by the infinite wisdom of the review staff. I'm personally so thankful that custom components have not [ yet ? ] been removed from the code base...

On Wed, Mar 9, 2022 at 1:23 PM Kevin @.***> wrote:

Also looking to do this. still no solution?

— Reply to this email directly, view it on GitHub https://github.com/home-assistant/core/issues/26553#issuecomment-1063385115, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASRFZJMT77XW3QKG7G5WZJTU7EJGPANCNFSM4IVEU77A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

[github-actions[bot]]

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

[petterreinholdtsen]

It is a bit funny, but mostly sad, to see how little hope there is to get such a feature, which alread had a patch provided, into the official package.

Happy hacking Petter Reinholdtsen

[rocket4321]

Thats why I long gave up on providing my code solutions to the Hass jerks

Jul 15, 2022 10:26:52 AM petterreinholdtsen @.***>:

It is a bit funny, but mostly sad, to see how little hope there is to get such a feature, which alread had a patch provided, into the official package.

Happy hacking Petter Reinholdtsen

— Reply to this email directly, view it on GitHub[https://github.com/home-assistant/core/issues/26553#issuecomment-1185751483], or unsubscribe[https://github.com/notifications/unsubscribe-auth/ASRFZJKHVVDQUVMT6S2C2I3VUGNNXANCNFSM4IVEU77A]. You are receiving this because you were mentioned.[Tracking image][https://github.com/notifications/beacon/ASRFZJIZNPOIBSYUSSJHGZTVUGNNXA5CNFSM4IVEU77KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOI2WSDOY.gif]

[petterreinholdtsen]

Sad to hear, but this issue for sure do not inspire much hope.

[issue-triage-workflows[bot]]

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

[petterreinholdtsen]

Patch is still being ignored, as far as I know.

-- Happy hacking Petter Reinholdtsen