J. Nick Koston

Results 1909 comments of J. Nick Koston

In https://github.com/home-assistant/core/issues/124099 we see the connection getting dropped. However the full log is missing so its hard to tell what is really going on there. It may be every time...

@mklokocka Are you using uvloop as well?

> > Not using uvloop. The trace back you posted has uvloop in it.

@mklokocka Does the problem still happen if you disable the patching of the internals in https://github.com/DataDog/dd-trace-py/blob/main/ddtrace/contrib/internal/aiohttp/patch.py ? The previous issues thatw ere reported focused on the `aiohappyeyeballs` [staggered race](https://github.com/aio-libs/aiohappyeyeballs/blob/main/src/aiohappyeyeballs/impl.py#L78), however...

Please update to [`aiohappyeyeballs` 2.4.8](https://github.com/aio-libs/aiohappyeyeballs/releases/tag/v2.4.8) and check if the problem goes away

Thanks. If the problem reoccurs, let me know and we can reopen

I've dug though the aiohappyeyeballs code again, and can find no place where we can work around this. so for uvloop, we are waiting for https://github.com/MagicStack/uvloop/pull/646 to get fixed upstream...

Disabling happy eyeballs will only reduce the chance the problem can happen with uvloop. There isn't anything we can do further but wait for uvloop to fix the issue.

https://github.com/aio-libs/aiohttp/pull/10464 was probably the most relevant change in 3.11.13

One difference between how `aiohappyeyeballs` and [that pr handles the `close`](https://github.com/aio-libs/aiohttp/pull/10464/files#diff-c143bd72e7f6748d879e5a0466a2872e05dc2d0b4a1157e9221702cc3c5516bbR1134) is that `aiohappyeyeballs` expects the `socket.close()` to be able to raise and traps it in https://github.com/aio-libs/aiohappyeyeballs/blob/e3bd5bdf44f5d187802de6dcb08d27e1ca6da048/src/aiohappyeyeballs/impl.py#L227 It probably makes...