Braden Kopenkoskey
Braden Kopenkoskey
> We could add an option to that node protodef type to allow large arrays. Keep it off by default And then propagate that option to pnbt This seems like...
@extremeheat and @rom1504, I have an open [PR in node-protodef](https://github.com/ProtoDef-io/node-protodef/pull/154) to address the proposed `skipChecks` option. Once that PR is reviewed and published, I have a PR ready for this...
@extremeheat do you have a recommended approach on this then? If I add a flag, it looks like I will need to add it to many of the functions that...
> Yes, you would need to propagate options to all the methods. Global is not good. 👍 I will work on that over the next few days and update here...
@extremeheat this is ready for re-review. Passes all the tests and it worked when I included it as the package for my project.
@extremeheat Hey! What's the status with the review? Do you need anything from me?
@extremeheat won't your proposal still set `noArraySizeCheck` globally? `setVariable` is setting the variable value in `proto` which will remain set after a `parseUncompressed` is made. What are your thoughts on...
@extremeheat Is there a contributors guide that outlines coding practices you expect in Prismarine repos? If you would prefer to rely on JavaScript's falsy behavior, we can go with your...
I updated the API doc to include details about the new options object.
@extremeheat lint fixed. Before merging, note we will need to merge and release #154 so we can use the update package here.