Braden Kopenkoskey
Braden Kopenkoskey
I fixed the `test` command so both Markdown and JS files are linted. Please let me know if there's anything else you'd like done in this PR.
> at the very least, we still should have semicolons in code Sure, I added a rule that overrides the `standard` default [no semicolon rule](https://standardjs.com/rules#semicolons).
@ctcpip I dropped the commit enforcing semicolons. Without modifying the lint rules, the linting will remove semicolons in a few files since that is what the `standard` config defines. This...
> I think you could make it so that only JavaScript files have semicolons, and markdown files don’t have semicolons. @bjohansebas that seems like a good intermediate solution. Updated!
It seems like there's not a clear direction with linting in the express project right now (https://github.com/expressjs/discussions/issues/327). I'll close this PR for now. If a linting standard is chosen, I'd...
> I'm of course also happy to extend the documentation site accordingly if this will be merged, I'd just need a pointer as to where I could contribute that. The...
I opened a pull request to fix this issue. https://github.com/diegomura/react-pdf-site/pull/142
@ipetersenpai Downgrade to version 3.4.2 for default fonts to work again. This is a duplicate of #2730.
@ipetersenpai make sure you have the dependencies pinned and re-install. For example `^3.4.2` is not pinned and will auto update to `3.4.4`.
@ipetersenpai can you share example code to reproduce the issue in `3.4.2`?