Ben Darnell

Results 362 comments of Ben Darnell

Ah, yes, it should be a 400 instead of 500. The try/except that turns HTTPInputError into a 400 is not in the right place.

What's the status of this? Are you waiting for me? It looks like the last build run at https://github.com/lysnikolaou/tornado/actions failed so I've been waiting for an update or a new...

No worries, take your time. I just wanted to make sure you weren't waiting on me and had successful test runs that I hadn't seen.

The mysql docs make a useful distinction between "Prepared Statements in Application Programs" (which are how prepared statements are normally used in practice) and "Prepared Statements in SQL Scripts" (i.e....

We have an open PR for this: #3338

Is this just spec lawyering or is there client software that does something useful with the Allow header? Returning an Allow header based on SUPPORTED_METHODS will not generally be useful...

`SUPPORTED_METHODS` is a whitelist to ensure that we don't call (via `getattr()`) a method that wasn't expecting to be called this way (e.g. `PREPARE / HTTP/1.1`). Handlers that support non-standard...

See also http://stackoverflow.com/questions/15684764/http-405-web-server-compliance

Yeah, I think we need a guide like that (especially when it comes to caching - getting the Vary header right can be tricky and must be left to the...

`args` is part of the de facto public interface of this class. We just jumped through some hoops to preserve backwards compatibility in this class in #3465. What exactly are...