Ben Darnell

Results 362 comments of Ben Darnell

The Future returned by wait_for_handshake is intended for use in coroutines. The new argument (which is the only one added by `add_done_callback`; the rest are bound in the `partial`) is...

Looks like h2spec has changed - we use it (https://github.com/bdarnell/tornado_http2/blob/master/tornado_http2/test/h2spec_test.py) and the tests passed last time this repo was touched (in 2017).

The reason this package exists is for "its own version of all that logic" - I wanted to implement http/2 to learn about it and because it's fun. :) I...

Well, this one is written by a tornado maintainer, so in that sense it has support :) My feeling is that it doesn't make sense to merge an HTTP/2 implementation...

Great, I'm glad it's working well for you. That's really all I've been waiting for before posting this is for someone other than me to report some success with it....

I'm just looking for some basic QPS numbers - how many "hello world" pages can it serve per second compared to the HTTP/1 version? Something like [this](https://github.com/tornadoweb/tornado/blob/master/demos/benchmark/benchmark.py), but with a...

Thanks for the patches, it's good to see someone trying out this library! For the max packet size check, I think it's better to do this chunking at a higher...

What would you want to do differently when handling this exception compared to a "real" exception? In my view the `get()` method is for queries that can never have multiple...

Yes, this error can definitely occur. But why does it need a distinct class instead of a generic Exception with an explanatory message? Why would you want to catch this...

SQL mode "TRADITIONAL" enables a number of options on the mysql server. Among them are NO_ZERO_DATE and NO_ZERO_IN_DATE, which make the server stricter about invalid DATEs and DATETIMEs. In this...