Ben Darnell
Ben Darnell
A complete code example for what?
It's true that the docs don't match the behavior here, but it's also worth looking at whether the current behavior is what we want. Why exactly was this an issue...
> I know that I have code that really on on_finish to clean up things that are setup in initialize additionally to cleanup things that are setup in prepare. OK....
> I don't think pings & pongs can carry any [meta]data, so it is not possible to associate a pong with the ping that it was responding to. As a...
Note that this PR hasn't shipped in a release yet. (Maybe this week?) Do you have any evidence that problems are still occurring with the most recent branch? Pings are...
In `tornado>=6.5`, `ping_timeout` cannot be greater than `ping_interval` (if it is, we set `ping_timeout = ping_interval` and log a warning. So without the tornado version check, you'd have both set...
> But somehow it seems to have worked to prevent connections from dropping without any known side effects. It's possible that this was avoiding bugs in the old implementation, maybe...
> Instead, in the add method, I will not allow the addition of a Content-Length header unless it meets the necessary criteria. I don't think `HTTPHeaders.add` is the right place...
I've got my own version of a fix for this in #3477
> especially with native runners now, I think quite a few packages go with dual wheels. Dual wheels are appealing because that's what we're doing on linux and windows. But...