Ben Darnell
Ben Darnell
Accept-language parsing was improved in #3068 so I think this PR is no longer needed; if there was something here that's not covered by that PR feel free to open...
Ah, OK. In that case my comment about the deeply-nested generator expression inside a for loop expression still stands.
I'm not sure where this would best be documented. You might be better suited to answer that than me - you needed this feature; where did you look in the...
I have no objections to this change (and I like that it shrinks the getattribute exception list). However, if you're using something like this `_get_selector` function, I'm not sure you...
What are your thoughts on this PR now, after time has passed and you have https://github.com/zeromq/pyzmq/pull/1524? Are you interested in getting it updated and merged or should we just close...
In general I think Union returns are ugly and it's usually better to standardize on one type or the other. I wish we could change `render` to return bytes, but...
Hmm, I wonder what changed. Debian unstable had a python3-tornado package at version 4.5.3 until March of this year. I assume it passed its tests then. The test failures are...
It doesn't look like openssl 1.1 is at fault (at least not alone). I built python 3.6 with openssl 1.1.0e (using [this docker script](https://github.com/bedefaced/python-openssl-docker)) and the tests of Tornado 4.5.3...
Works for me with my macports-based installation of python 3.7 (well, it doesn't completely work, but it doesn't get those "timed out after 5 seconds" errors). ``` [bdarnell@rowlf ~]$ python3...
OK, I can reproduce this now: it appears that the key is openssl version 1.1.1 (not 1.1.0e, which I had tried, or 1.1.0g in bionic). If I build Python 3.7...