tornado icon indicating copy to clipboard operation
tornado copied to clipboard
verified publisher icon tornadoweb

Enhance parsing of Accept-Language quality values

Open spaceone opened this issue 7 years ago • 5 comments

Parse HTTP syntax correctly: Accept-Language: en-US ; foo=bar; q=2.0 was not possible and is now possible.

spaceone avatar Dec 03 '18 18:12 spaceone

Thanks for your contribution! Can you add a simple test case for this functionality to web_test.py?

bdarnell avatar Dec 07 '18 15:12 bdarnell

@bdarnell Added a test case with all tests passing.

spaceone avatar Jan 28 '22 20:01 spaceone

Accept-language parsing was improved in #3068 so I think this PR is no longer needed; if there was something here that's not covered by that PR feel free to open a new one.

bdarnell avatar Aug 28 '22 16:08 bdarnell

no, this is an additional MR on top of #3068 - and already rebased up on it. please reopen.

spaceone avatar Aug 28 '22 18:08 spaceone

Ah, OK. In that case my comment about the deeply-nested generator expression inside a for loop expression still stands.

bdarnell avatar Aug 28 '22 18:08 bdarnell