Ben Darnell

Results 362 comments of Ben Darnell

The issue description is still valid. The `xheaders` and `trusted_downstream` options let you find the IP via which the request entered your network. The `X-Forwarded-For` header may contain additional untrusted...

I don't use freebsd so I'm not going to be much help here but I can give you a few pointers. The 4 non-daemon threads belong to a ThreadPoolExecutor created...

I'm not sure about `add_callback_from_signal` these days. It calls asyncio's `call_soon_threadsafe`, which was also signal-safe when I looked at it a long time ago, but it's not documented or guaranteed...

It's hard to say without any detail about what you're doing, but my guess is that you're doing something that is blocking the IOLoop thread. Try setting the environment variable...

I don't know of anything in Tornado that could cause a file download to take 20 minutes, unless maybe you're running some massive computation on the main thread (I don't...

Interesting, this isn't how I read #2958. I thought that issue was about `on_close` being called when `open()` was never called in the first place. This looks like it's a...

Yes, this would be a good feature. I think you may be able to do something like this today with the `Resolver` interface: Make a wrapper resolver (similar to OverrideResolver)...

A boolean argument that changes the return type is not a great solution (and mypy doesn't like it). I think a better long-term solution is to split the write_message interface...

You're right, this isn't working. The defaults are used when the request object has `None`, but there's always a non-None value for `headers`. There's not a clean simple way to...