Ben Darnell

Results 362 comments of Ben Darnell

@BrandonTheBuilder OK, so the `contextvars` discussion is mostly a distraction for this PR. Let's keep the discussion here focused on what it would take to support `current_task`, and move any...

I don't have any plans to work on this, but I think it could be useful. I wouldn't want to add a third-party dependency for it, though, so I think...

What do you mean by "break the connection"? There are a number of open issues about "task was destroyed but it is pending", but it's really difficult to tell what's...

Closing due to inactivity

Hmm, this is messy. `websocket_connect` tries to jump into the HTTP stack in the middle so it doesn't have the full AsyncHTTPClient available. There are a few ways this could...

This looks like a bug when following redirects: some errors from the second request aren't getting raised correctly. This probably affects asynchronous usage as well as the synchronous HTTPClient, although...

This looks like an oversight - `on_close` should only be called if `open` has been called (`on_connection_closed` may be called whether the websocket handshake has completed or not, but `on_close`...

> Wouldn't it be better if tornado completes the URI or at least give a chance to do it? How would it be better? Personally I haven't run into problems...

I think that it makes sense for methods like `reverse_url` that *produce* urls to take an `absolute` argument (we have some related functionality although we're not consistent in terminology. `static_url`...

I'll look into setting up something more formal, but for now my email address is in nearly every merge commit in this repo.