Shahar Soel
Shahar Soel
Hi @matz3 Can you provide a reproducible scenario?
Thanks for the information and initial investigation @matz3 👍 I suspect it may be related to this code snippet - https://github.com/SAP/ui5-language-assistant/blob/da2682e474ff13d42ad913a6c7e57bb65d546f66/packages/language-server/src/manifest-handling.ts#L80-L84 It is possible we need to `glob` more "gentle"...
I did a quick change trying to exclude `node_modules` folders from that glob pattern. > return globby([`${workspaceFolderPath}/**/manifest.json`, `!**/node_modules/**/manifest.json`]); Can you try reproducing the issue again with this change (vsix below):...
Relevant code is here: https://github.com/SAP/ui5-language-assistant/pull/265
> Maybe it's also related to the number of manifest.json files within the workspace? Perhaps the combination of cyclic folder structure and many manifet.json files is causing a bug with...
How important is this to you? I could try re-producing the scenario you have described, but right now I do not have accesses to that "internal" repo, perhaps I will...
This causes coveralls voter to fail if it detects reduction in code coverage percentage.
Logic for links generation can currently found here: - https://github.com/SAP/ui5-language-assistant/blob/master/packages/logic-utils/src/utils/documentation.ts#L193-L201
In the LSP specs this matches `Hover.range` - https://microsoft.github.io/language-server-protocol/specifications/specification-current/#textDocument_hover ```typescript /** * The result of a hover request. */ export interface Hover { /** * The hover's content */ contents:...
Should be some automation in the CI, and should measure versus previously release version to detect regressions.