Shahar Soel

Results 254 comments of Shahar Soel

Thanks @iarna that is very convenient that the compliance tests are extracted to a separate repo. 👍

> Evaluate performance advantages of not using the CST for this. Parsing seems 50-70% faster when not building the CST. So its likely ~50% performance boost could be gained by...

Hmm, looks like this is implemented new code in gitpod branch using localStorage - https://github.com/gitpod-io/openvscode-server/blob/0b970a96e5506af2caaaa19d704bb069691255b8/src/vs/gitpod/browser/workbench/workbench.ts#L42

Some potentially relevant productive examples in the context of LSP / Editor Services. - MetaBase Expression Language + Auto Complete - [Source](https://github.com/metabase/metabase/blob/136dfb17954f4e4302b3bf2fee99ff7b7b12fd7c/frontend/src/metabase/lib/expressions/parser.js) - ArgDown LSP - [Source](https://github.com/christianvoigt/argdown/tree/master/packages/argdown-language-server) - [Parser](https://github.com/christianvoigt/argdown/blob/master/packages/argdown-core/src/parser.ts) -...

Thanks for the feedback @erlethor 👍 > Navigation / go to definition (most helpful) This seems very useful, it is also fairly complex as we currently do not yet any...

Hello @mschleeweiss It will likely be require more than a **porting** of said parser. I am not familiar with the specific `ExpressionParser` in UI5. However, in general a parser meant...

@fausto-m the build matrix fails, can you please fix so I can start the review process. @petermuessig WDYT of this feature?

Hi @uxkjaer I am a bit conflicted about this feature: **Pros:** - it is quite cool - and may be useful. Cons: - It is not quite the regular "go...

Good points I will setup a meeting with you and the relevant product person 👍