Shahar Soel

Results 187 comments of Shahar Soel

## Tasks - [ ] Expose relevant method on the [tree builder parser trait](https://github.com/SAP/chevrotain/blob/master/packages/chevrotain/src/parse/parser/traits/tree_builder.ts). - [ ] Document the new API in api.d.ts CstParser class. - [ ] Should there...

Thanks for helping @drayavannie, lets track everything in this single issue?

Hi @tlrobinson The simple examples certainly helps. 👍 I don't think the recovery logic handles the edge case of EOI. - [Relevant Source Code](https://github.com/SAP/chevrotain/blob/master/packages/chevrotain/src/parse/parser/traits/recoverable.ts#L232-L253) ```typescript canRecoverWithSingleTokenInsertion( this: MixedInParser, expectedTokType: TokenType,...

All-right, I've debugged this again but this time using a full dev env instead of the playground. Adding an EOF token explicitly seems to resolve the problem. ```javascriptt $.RULE("expression", ()...

I've started looking into this and it does not seem that removing this feature will actually git rid of significant amount of productive code. (~150 LOC). Maybe it is best...

I am not sure if categories should be rendered as none terminals as that may be misleading: - They are not grammar rules and have different semantics. But I agree...

More feedback from @matthew-dean > For visitor methods (https://sap.github.io/chevrotain/docs/tutorial/step3a_adding_actions_visitor.html#introduction), I would have expected that this.visit, if visiting an array, would return an array of visit results. However, that does not...

> Can we separate the validations of "all visit methods implemented" and "redundant visit methods found"? Redundant visit methods validation was removed in https://github.com/Chevrotain/chevrotain/pull/1847

> Is it possible for you to assign me to this issue or do I need to be a member of the repository for that?

I'm a little hesitant to add more capabilities to the Lexer. I'm actually trying to simplify it now by reducing the number of supported Token types as its maintenance has...