Benjamin E. Coe

Results 350 comments of Benjamin E. Coe

@JustinChristensen one problem is that v8 output won't necessarily have all the same branch information, as it collapses together consecutive blocks. I think this problem might be better solved by...

@tomardern what's the expected behavior? should we just be dropping `webpack://` in this case?

@rwalle I would consider a patch for this. I think we should warn on the console as well as setting `this.rawSourceMap = null`, if we have metadata indicating a source...

@ab2d3e8 I'm not following what you're trying to do, are you sure this is the right library?

Hey @jayp 👋 we're in the process of [converting this library to TypeScript](https://github.com/googleapis/nodejs-tasks/pull/317), which should help a ton with regards to documenting these available options.

@bhargav175 would love the help getting builds running more smoothly 👍 and appreciate any other contributions you would like to make to this site. We worked with the creator of...

@jedwards1211 seems like a great idea to document this better, I'll update this thread with some thorough information about how coverage is collected when I have a few more cycles...

@dangreen @designbyadrian thank you for the bug report, are you able to pin the dependency for the time being? Hopefully @hutson or myself can dig into soon :clap:

> Am I missing something here? The implementation looks right, but I think it is just miss-represented in the grammar spec. @wesleytodd this was intentional on my part, I see...

@byCedric @wesleytodd having been playing around a bit with a tree visitor, it jumps out at me that we'll probably also want to add `(`, `)`, and any other tokens...