Bertrand Coconnier

Results 203 comments of Bertrand Coconnier

> from a user perspective it just feels weird, especially since things like fuel lines are not actually modeled. Indeed JSBSim does not hard code a fuel system. But it...

> By the way, sorry if the feature requests are supposed to go to Discussions, I did not know that feature even existed on GitHub. No worries. Bugs and feature...

I have given some thoughts to this issue and there are a number of topics I'd like to clarify. @valtsu41 said: > I know that that method exists, and the...

> I'd noticed you periodically having to change the initial theta angle in the initialization file for the Short S23 aircraft in order to ensure that the trim solver found...

Following your findings, I have checked if `gamma` was already used in our models and there are only a few models that use it in their initial conditions: https://github.com/JSBSim-Team/jsbsim/blob/647510208c3e88ee9393b68351d591c09c2beecf/aircraft/737/cruise_init.xml#L9 https://github.com/JSBSim-Team/jsbsim/blob/647510208c3e88ee9393b68351d591c09c2beecf/aircraft/737/cruise_steady_turn_init.xml#L9...

As you may have noticed, I had to change yet another time the files ` aircraft/Short_S23/reset01.xml` and ` aircraft/Short_S23/reset02.xml` in commit c0b46aa74d19ad79aa91c551e4ed5ad548d55863 I tried adding `gamma = 0` but to...

I took the opportunity of this PR to fix the test `TestInputSocket` so that it should now work on Windows and MacOSX. I removed the threading code altogether as this...

Honestly, I don't know what `Messages`was designed for. @jonsberndt, any idea ? I can only find a pair of references to the methods `FGJSBBase::*Message`: https://github.com/JSBSim-Team/jsbsim/blob/0e842e751373f70ac927cef87a68a6e8fd1129df/src/models/FGLGear.cpp#L546-L551 https://github.com/JSBSim-Team/jsbsim/blob/0e842e751373f70ac927cef87a68a6e8fd1129df/src/models/FGLGear.cpp#L563-L568 Both of these occurrences...

> I create a temporary fix for this issues: > > ### Methods > 1. Move the static variable(message, debug_level and other stuff) in FGJSBBase into a standalone struct CommonData....

You're perfectly correct in raising all these usage of the `static` keyword as needing some rework ! :+1: In most cases, the current design is bad and is a result...