Bertrand Coconnier

Results 203 comments of Bertrand Coconnier

Of course, this implies that `CIGI_cache` keeps track of the order in which the gears are queried.

> Hmm, just remembered that there is at least 1 other call to the ground callback that doesn't come from the gear/structure contacts, and that's to calculate the AGL for...

> It might also be a good solution to add the gear index or reference to gear object in the callback function parameters. Then user wouldn't need to maintain a...

> I'm not sure how much of a deal backwards compatibility is. The management of the C++ API backward compatibility has historically been quite relaxed. However we should avoid breaking...

> Would have to be a `const` pointer since remember the ground callback is also called by JSBSim to get the AGL of the aircraft's cg, i.e. without a specific...

BTW if we break backward compatibility we could go frankly and redesign the current hideous interface of `FGGroundCallback::GetAGLevel` (passing arguments by reference so that they get updated is soooo 90's...

> Doh, guess i conflated it with .csproj(s) which i have more experience with. @jamesford42 So should this issue be closed ?

Since this topic has not seen any progress in months and it is not addressing either a bug report or a feature request, it is moved to discussions.

> The straightforward way to address this requirement is to replace all the calls to `new` and `delete` by smart pointers (i.e. `unique_ptr` and `shared_ptr`). Due to the design of...

@XueSongTap, yes sure ! Just make sure to avoid submitting a huge PR with all the classes migrated to smart pointers at once. I'd rather suggest to start with a...