Boris Cherny

Whoops, when I wrote that comment I thought I was in a different repo 😅. Two things: 1. This package is not yet ready to use (see https://github.com/bcherny/flow-to-typescript/issues/1) 2. When...

My guess is `DeclareClass` is a Flow type (which expects only Flow types as children), while `TSTypeLiteral` is a TS type. This might be a limitation of the walker approach...

Hey, thanks @jthegedus! I do, but it's on my back burner. I started working on this, then realized two things: 1. The babel-types typings are really incomplete and inaccurate. I...

Thanks for the report! It's hard to help without a reproducible case. Can you please comment with a self-contained, reproducible example of the bug?

This is tricky. We want to say "additional properties should be X, but not Y". I worry that unioning with `unknown` is too permissive. This is a TypeScript feature request,...

Hey there! In this case, it's not clear to me what the expected behavior is here. It really is a contradiction that `s` must be both a string, and an...

Maybe JSONSchema and TS have different semantics here: ```ts export type S = { s?: string; } & { [k: string]: { foo?: string; [k: string]: unknown; }; } let...

While I’m not sure it’s technically feasible to guarantee that the result typechecks, maybe we can start by doing better in this case in particular.

Here’s the TS issue that blocks this one: https://github.com/microsoft/TypeScript/issues/17867. I’d love ideas for a workaround if someone has one, but I’m not sure there’s a great way to do this...

That's a great suggestion @ellis! Since these go in the `format` field and don't refer to types, the best we can do is generate type aliases (we can think about...