Boris Cherny comments

Results 252 comments of


                                            Boris Cherny

Improve output for top level $ref

Thanks for the reports @dherges. @BigstickCarpet Is Example A kosher?

Improve output for top level $ref

@dherges Can you post the complete JSON-Schema for Example B? From what you gave it's not clear to me why the output is incorrect.

Improve output for top level $ref

@BigstickCarpet As always, thanks for chiming in. @dherges You heard it here, Example A is invalid. For example B, nicer output might be: ```ts export type ExampleSchema = Person export...

Improve output for top level $ref

@dherges Can you chime in?

Provide option to generate inline types instead of named interfaces

> We need this to because we want to form an object with inline types: Could you explain why you want this, and why you couldn't just reference the emitted...

Questionable output when property title is "Symbol"

@meeq, what behavior would you expect?

Feature request: Emit unsupported JSON-Schema directives as code comments

@anonimitoraf @brettz9 Want to start by spec'ing out JSONSchema properties, and the output that you'd expect for each? That will help guide how we implement this.

Duplication of type : properties with different description

Hey @maximeag! I think we'll need a few more examples from others to make a call on this one. I'll leave it open for now. For what it's worth, since...

Feature request: Support OpenAPI's "discriminator" directive

Will leave this open for now, in case there's interest from others in this feature.

`title` in property should means a short description

Hey there! This would be a backwards-incompatible change. Let's leave this issue open to collect feedback from others -- if there's enough demand, we can change the behavior.