Boris Cherny comments

Results 252 comments of


                                            Boris Cherny

Add `x-enum-varnames` support

> @galah92 I have a couple open questions for @bcherny. I can pick this back up when he answers Sorry I missed this! The status was Changes Requested, so I...

Broken generation with additionalProperties

This is a bug, and we should find a better way to handle this case. One option is to always emit index signatures as `[k: string]: T | undefined`. In...

[bug] $ref resolve uses wrong root dir

Sorry for the delayed response! Feel free to continue work on the PR to resolve requested changes.

when schema is: {type: "object", default: "foo"}, the result type is: type Schema = string;

What does it mean for `default` to be a string, while the `type` of the schema is an object? JSON-Schemas accept the *combination* of the different types they *may* be;...

Enhance tsEnumNames

@vaskevich I'm not sure JSON-Schema supports that. If you can point to where in the spec it does support it, we can add support in JSTT as well.

Formatting seems to use non-standard Prettier options by default

Contributions welcome! I’d suggest starting with a good repro case.

Support additionalProperties index definition

This is a neat idea, but I don't think it jives with the specification. https://json-schema.org/latest/json-schema-validation.html#rfc.section.6.4.2 Do you have a specific use case, and a proposal for how we could extend...

replace cli-color to something else

Thanks for the (slightly snarky) flag!

Adding allOf generates intersection types

Hey there! Does adding `"additionalProperties": false` to your `allOf` cases fix the issue for you? What output would you expect for the `allOf` -- nothing?