Boris Cherny

Results 252 comments of Boris Cherny

Thanks @umar-siddiqui! A few things: 1. Don't forget to bootstrap your Angular app. 2. We only support Angular 1.5+. If you'd like to add support for older Angular versions, feel...

Thanks! That’s a great idea - contributions are welcome!

Hey there @chigix, thanks for the contribution. Once you have a chance to fix the TypeError (see CircleCI output), I'll be happy to merge this. https://circleci.com/gh/bcherny/tslint-no-circular-imports/43

Thanks for the thorough report @chigix! This is a bug - it looks like we’re not emitting the correct terminal node. The fix here is probably a 1-liner, plus a...

Awesone!! - [noCircularImportRule.ts]( https://github.com/bcherny/tslint-no-circular-imports/blob/master/noCircularImportsRule.ts) is the file you want to update - To create a new test case, just add a folder called case5/ with a few files that have...

@JoshuaKGoldberg What exactly is the bug here? Did you dig into it?

It's hard for me to debug without being on Windows, but could it be related to hard coded path separators in test cases? Eg. https://github.com/bcherny/tslint-no-circular-imports/blob/8c7e2984aa67d80d6e2069b7d68d2a3c05504d63/test/test.ts#L31

yes - icons still look bad on retina: can we just serve the SVG instead of PNG? svg is: - [supported by all modern browsers](http://caniuse.com/#feat=svg) - compatible with higher dpi...

This would be huge. In something like Scala, macros are a way for the community to implement and test out new language features that are not yet (or will never...

@elibarzilay With that approach, would macros be typesafe? If the whole point of TS is to be a typesafe layer on top of JS, macros should ideally also be typesafe....