Brian J. Cardiff

Results 129 comments of Brian J. Cardiff

@rishavs I think the situation you are in is the same as #136. PR are welcome accordingly to #113.

As long as you are not checking out connections explicitly the pool should be able to recover from temporary outages. Sample in mysql https://crystal-lang.org/reference/database/connection_pool.html Maybe an exception with the wrong...

`query_all` should return an Array with one element per row `query` will yield a result set that you are responsible to iterate. The documentation for such methods live in http://crystal-lang.github.io/crystal-db/api/latest/DB/QueryMethods.html...

The entry point for prepared vs unprepared statement is at: https://github.com/will/crystal-pg/blob/master/src/pg/connection.cr#L20-L26 . They are all unprepared under the hood.

Maybe. It depends on the underlying implementation or protocol. In mysql the binary and text protocol that are used for prepared or unprepared statements is very different. In sqlite all...

Actual datatypes arr determined by the db/driver in the `ResultSet#read`. Types in `#read(T)` are used for better typing the crystal expression but the default implementation does not use that information...

A db can hold more values than then json format can represent. And there are not always a clear winner on how to encode it. Meanwhile https://manas.tech/blog/2017/01/16/from-a-db-to-json-with-crystal.html might offer some...

@nelfer you might like this change if you still use the container.

Hi, @zixia I exposed some concerns regarding your requested changes. Let me know if those thoughts make sense to you.