Ben Brooks

We've avoided it where possible (without too much effort), but it seems unavoidable given the v8 work Hopefully a case of just adding some more steps to the worker node...

@adamcfraser I think this PR is finally good for a fresh review! Thanks

Some more feedback after testing: ## Default collection The response for the default channel doesn't match the response format for collections, and doesn't contain any sequence information. They should be...

Can you rebase/fix tests before I review again?

1. The change to include channel source has affected the logging, which I think we should probably try to keep the same. E.g: ``` 2024-03-13T13:51:45.320Z [INF] HTTP: c:#009 db:db1 PUT...

It's possible to make SG panic by giving a user a non-existent role (which is a valid thing to do - roles can be created/updated after the fact), and then...

I noticed in my previous comment we're marshalling source incorrectly too. ``` "admin_channels": { "def": { "seq": 3, "source:omitempty": "Admin" }, ``` Note: `"source:omitempty"`

Showing source in the API response seems redundant given they're already bucketed into `admin_grants`, `dynamic_grants`, etc. I think this is just a case of making the `Source` field in `GrantHistory`...

Admin-assigned roles also appear in the dynamic_role_grants section for some reason. This role was created/assigned using only the admin_roles / admin_channels fields on the Admin API. ![Screenshot 2024-03-14 at 13...

Ignore - I was using stale bucket data from a previous version of this PR Now no channels are appearing. I've tried re-updating the user to make sure nothing is...