Bryan Boreham
Bryan Boreham
When creating dummy data for benchmarks, call `Commit()` periodically to avoid growing the appender to enormous size. To illustrate, ask Go to run nonexistent sub-benchmarks so it just does the...
I filed this as a Go bug since it is architecture-specific, but cross-posting here for visibility: https://github.com/golang/go/issues/71408 This code: ``` type Metadata struct { Type string `json:"type"` } func TestJsonIter(t...
### Proposal Users frequently come with questions about absurd results from `rate`, etc., when their problem is that the underlying data is oscillating. Here is an example of oscillating underlying...
Restarting the depth-first walk on each leg of a binary expression is convoluted. ISTM the correct logic is to walk the path backwards to the first relevant function.
Note: branch is based on #16702, otherwise `detectHistogramStatsDecoding` restarts the tree-walk on every binary expression which makes everything much more expensive. This is not the use-case I want to optimise,...
Binary operations generally involve matching left-hand series against right-hand series, for which we had the `prepSeries` function pre-computing signatures. The genesis of this refactor is that I didn't understand what...
Vendor dir should be removed similar to #7572. From the `Makefile`, it is currently using Go 1.12.1, which is quite old and not receiving security patches. Unwisely pulling on the...
Update of #6791, resolving merge conflicts and adding changelog. I also proposed a couple more commits rearranging things to avoid duplication between 8-byte and 16-byte versions of the same code;...
### Proposal Prometheus has `label_name_length_limit` and `label_value_length_limit`, currently defaulted to no limit. After #16069, Prometheus will crash if you give it a name or value longer than 16MB, so we...
Primarily this is to document that Postings must be ordered. The description of `Seek()` implies they are, but it's better to be explicit. I modified the unit tests for `ListPostings`...