Bryan Boreham
Bryan Boreham
This is consistent with [the OpenTelemetry standard](https://github.com/open-telemetry/opentelemetry-specification/blob/89aa01348139/specification/metrics/data-model.md#exemplars), and [an example in OpenMetrics](https://github.com/OpenObservability/OpenMetrics/blob/138654493130/specification/OpenMetrics.md#exemplars-1). There was only one place outside of tests and documentation that Prometheus used `"traceID"`, in `rules/groups.go`. This is...
This builds on #10991, implementing "Option 5" in the [design doc](https://docs.google.com/document/d/1fXrPI2kr-jUvkF9JkkA7aPk7UQYTG9Yvk6A-fSinqEU/edit?usp=sharing). The code adds a new `labels.Labels` implementation which can be selected at build time with `-tags dedupelabels`. ~This branch...
Failed here: https://github.com/prometheus/prometheus/actions/runs/7797756253/job/21265037848?pr=13545 ``` === RUN TestAsyncRuleEvaluation/asynchronous_evaluation_of_all_independent_rules,_insufficient_concurrency manager_test.go:1961: Error Trace: D:/a/prometheus/prometheus/rules/manager_test.go:1961 Error: "0.0655291" is not less than "0.06" Test: TestAsyncRuleEvaluation/asynchronous_evaluation_of_all_independent_rules,_insufficient_concurrency --- FAIL: TestAsyncRuleEvaluation (0.18s) --- FAIL: TestAsyncRuleEvaluation/asynchronous_evaluation_of_all_independent_rules,_insufficient_concurrency (0.07s) ``` Passed...
### Is your feature request related to a problem ? https://github.com/prometheus-community/helm-charts/security says to follow the Prometheus security policy, which is a long document but includes this: > If you find...
It was parsing `args[0]` but reporting an error on `args[1]`, which might panic and obscure the error. Also do the initial parsing earlier, to save effort reading the core if...
This is from https://github.com/prometheus/prometheus/pull/5312; the code moved to this repo since that PR was opened. @geekodour is the original author.
I looked at `go_gc_heap_allocs_by_size_bytes_bucket`, and found it strange that the buckets include `le="24.999999999999996"` and `le="64.99999999999999"`. With help from @beorn7 I believe this is because the bucket is defined as "less...
We have server-side TLSConfig in `exporter-toolkit/web`, and client-side TLSConfig in `common/config`. Exporter-toolkit is marked as "currently WIP and experimental". We should factor it out, enable common config changes, e.g. disable...
This code: https://github.com/prometheus/common/blob/1d8c67263f0058f5eda479684dec5751eaa1468b/model/labelset.go#L135-L138 will sort `foo2="bar"` before `foo="bar"`. The usual sort order of Prometheus labels is alphabetical by names, which would put `foo` before `foo2`.
I'm writing this to make the situation clear for projects that depend on this repo. `weaveworks/common` was created at Weaveworks, for the Weave Cloud service. Today Weave Cloud is shut...