Bryan Boreham comments

Results 835 comments of


                                            Bryan Boreham

nomad service discovery: add support for filtering by service or tag

Hello from the bug scrub again! We remain short of knowledge about Nomad. Do you know someone who could volunteer to maintain this code?

optimize regex matching for empty label values in posting match

Is there a test covering this case?

PromQL: Dot in regexp should also match newlines (which is less surprising to most users and also allows optimising the `.* `regexp)

I think ignoring newlines matches the expectation of most users of Prometheus.

notifier: stop queue filling due to single failed AM

Hello from the bug-scrub! @krajorama do you think you will come back to this?

[FEATURE] Kubernetes SD: Allow attaching namespace metadata to targets

Current code stats are +682 −2,445, with several entire files deleted; did something go wrong with git?

[FEATURE] Kubernetes SD: Allow attaching namespace metadata to targets

Hello from the bug-scrub! @PaulBarrie will you come back and resolve the issues with generated code, and the merge conflicts that have developed? Also it's unclear whether you have resolved...

promtool: Buffer piped unit test rule input to a tempfile

Hello from the bug-scrub! Since there was an objection, and no update since last visit, we will close.

query: skip over missing samples for vector expressions

> It would be really helpful, if you could point me to where I could add these unit tests and benchmarks (which files/directories to look at). Tests are in files...

tsdb: add details to duplicate sample error

In the context where I started working on this, called from Mimir, it already prints the full set of labels.

tsdb: add details to duplicate sample error

> remote writing to mimir (so mimir never sees the duplicate write attempt) @jhoblitt I am unable to parse this. Suggest opening an issue and providing full details.