Benjamin Bannier

Support skipping comments in `CsvReader`

1

It would be great if datafusion had out-of-the-box support for skipping comment lines. While non of this is "standardized" many CSV readers support skipping full comment lines. An often used...

Methods `inOut*` broken for directed graphs

5

It looks to me that most of the methods `inOutEdges` or `inOutNeighbors` are implemented incorrectly for directed graphs. All these methods use the adjacency matrix to access edges, e.g., https://github.com/ZigRazor/CXXGraph/blob/ae9bc563ad24f329da55c08a0c71e30ac818937c/include/CXXGraph/Graph/Graph_impl.hpp#L715-L725...

Unify analyzers for OpenVPN

1

Currently we have a number of OpenVPN analyzers. These analyzers seem largely identical with the only major differences being what kind of traffic they analyze (TCP vs. UDP), and their...

Test analyzers against Zeek test suite

1

Since some analyzers in this plugin explicitly replace builtin Zeek analyzers, we should consider testing them against the respective Zeek test suites to ensure users don't see regressions when installing...

This PR contains a number of cleanups of the project. - Move most project config from `setup.py` to `pyproject.toml`: with this one can use modern tools like e.g., rye or...

With zeek/spicy-ldap moving into Zeek with zeek-6.1.0 the package cannot be installed on >=zeek-6.1.0 anymore. We usually document this in the package README, but it would be great if we...

I am wondering whether it wouldn't make sense to add a subcommand which triggers generation of the package documentation, e.g., similar to [cargo-doc](https://doc.rust-lang.org/cargo/commands/cargo-doc.html). The package manager should already be aware...

Concurrent `zkg create` operations can race on update of default package source

4

While working on zeek/package-template#4 I noticed that multiple concurrent `zkg create` operations can race on update of the default package source. I did not check which other operations can trigger...

Overriden `ZKG_DEFAULT_TEMPLATE` ignored if also using `--configfile`

2

One should be able to override a configured `templates` by setting `ZKG_DEFAULT_TEMPLATE`. This seems not to work when also using `--configfile`. Reproducer in `zeekurity/zeek:5.0.2` image: - create a config file...

The machinery currently cloning the template repository breaks if the configured template is in a Git detached HEAD state, e.g., in image `zeekurity/zeek:5.0.2`: ```console # Create valid template repo, but...