Benjamin Bannier

When installing a package `zkg` by default runs the unit tests of the package, and not running unit tests requires explicit opt-out via `--skiptests`. We use this behavior e.g., to...

We would previously trigger workspace analysis if a `Cargo.toml` had any `workspace` entry even though we ultimately cared about `workspace.members`. This caused empty reports for files which used `workspace` only...

I am working on a project which uses a `cargo-dist`-generated `workspace` section, e.g., ```toml # Config for 'cargo dist' [workspace.metadata.dist] # The preferred cargo-dist version to use in CI (Cargo.toml...

Unsafe shifts not do not raise an exception

3

When shifting a safe integer beyond its width I would expect this library to raise an exception; instead I run into an assertion failure. ```cpp #include "SafeInt/SafeInt.hpp" // Shift an...

Zeek versions violate semver

5

Zeek version strings follow the schema `MAJOR.MINOR.PATCH[-LOCALVERSION][-debug]` where `LOCALVERSION` can be injected at configure time via `--localversion` and `-debug` gets appended for builds configured with `--enable-debug`. This violates [semver](https://semver.org/) which...

I see segfaults when trying to call `Broker::create_master` in module scope. I would have expected this to work, or at least be rejected with a diagnostic. ```zeek # foo.zeek const...

Implement some form of shadowing

2

Currently Zeek does not allow to shadow an existing identifier from a higher scope which can lead to unexpected name collisions (e.g., when adding to a module in a different...

I would expect the following code to either work at runtime or be outright rejected: ```zeek # foo.zeek event zeek_init() { local vs: set[set[string]] = { [ set() ] };...

We currently do not evaluate `&requires` attributes on vector elements, e.g., I would expect the following to fail with a `&requires` error, but instead reach `"unreachable"`. ```ruby module foo; public...

Disallow attributes on "type aliases" in parser

3

With #1890 we added a validator to reject any attributes on "type alias". To detect such type aliases we used a pretty nasty hack, https://github.com/zeek/spicy/blob/500f2852f22e6dc01cd84ed717c0441c8483f47e/spicy/toolchain/src/compiler/validator.cc#L360-L363 We should clean this up...