bb7133

Results 30 comments of bb7133

Just a ping, @henng may you update https://github.com/pingcap/parser/pull/577 please?

Thanks for the reporting... TiDB does not support geo-spatial types, that's why they're not included in current parser.

Could you add a test case for this change?

We have those cases run in CI of course, but by Bazel(https://github.com/pingcap/tidb/issues/34083) They are all flaky tests, when they run by Bazel, most of the time they will success because...

Hi @fanrenhoo thanks for your contribution. > Remove the historical duplicate records when upgrading. You can take upgradeToVerXXXX in session/bootstrap.go as an example. IMHO the challenging part here is how...

> Do you have any more concerns about this PR? @zimulala @bb7133 @Benjamin2037 To be frank, I don't get the point of your code...could you make some explainations on how...

This is a known difference: > Default collation: > * TiDB’s default collation is utf8mb4_bin. > * MySQL 5.7’s default collation is utf8mb4_general_ci. > * MySQL 8.0’s default collation is...

> resignation, job changes We do not nominate reviewers/committers because "they have some jobs". I think it's better to add the 'inactive roles' when those reviewers/committers do not participate in...