pd icon indicating copy to clipboard operation
pd copied to clipboard

scheduler: skip evict-leader-scheduler when setting schedule deny label

Open HaoW30 opened this issue 1 year ago • 17 comments

This commit comes from https://github.com/tikv/pd/commit/463297be6a621183386105525e0aa33a5fc09ebd.patch

DO NOT MERGE

What problem does this PR solve?

For testing

Issue Number: Close #xxx

What is changed and how does it work?

PD FIX

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below) x
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

Nothing

NOT FOR RELEASE

HaoW30 avatar Dec 20 '24 01:12 HaoW30

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign lhy1024 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Dec 20 '24 01:12 ti-chi-bot[bot]

Hi @HaoW30. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot[bot] avatar Dec 20 '24 01:12 ti-chi-bot[bot]

Now you can start all CI jobs with /test all in comment or query the triggers with /test ?

ti-chi-bot avatar Dec 20 '24 01:12 ti-chi-bot

/ok-to-test

HaoW30 avatar Dec 20 '24 01:12 HaoW30

/test all

HaoW30 avatar Dec 20 '24 01:12 HaoW30

/test all

HaoW30 avatar Dec 20 '24 02:12 HaoW30

/test

HaoW30 avatar Dec 20 '24 17:12 HaoW30

@HaoW30: The /test command needs one or more targets. The following commands are available to trigger required jobs:

/test build
/test integration-copr-test

Use /test all to run the following jobs that were automatically triggered:

tikv/pd/release-8.1/ghpr_build

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot[bot] avatar Dec 20 '24 17:12 ti-chi-bot[bot]

/test

rleungx avatar Dec 25 '24 08:12 rleungx

@rleungx: The /test command needs one or more targets. The following commands are available to trigger required jobs:

/test build
/test integration-copr-test

Use /test all to run the following jobs that were automatically triggered:

tikv/pd/release-8.1/ghpr_build

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot[bot] avatar Dec 25 '24 08:12 ti-chi-bot[bot]

According to https://github.com/tikv/pd/blob/feature/release-7.5.1-20241126/.github/workflows/pd-tests.yaml#L10-L16, the branch name does not match the format.

rleungx avatar Dec 25 '24 08:12 rleungx

/test

HaoW30 avatar Feb 28 '25 18:02 HaoW30

@HaoW30: The /test command needs one or more targets. The following commands are available to trigger required jobs:

/test build
/test integration-copr-test

Use /test all to run the following jobs that were automatically triggered:

tikv/pd/release-8.1/ghpr_build

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot[bot] avatar Feb 28 '25 18:02 ti-chi-bot[bot]

/test all

HaoW30 avatar Feb 28 '25 18:02 HaoW30

/test all

HaoW30 avatar Mar 10 '25 21:03 HaoW30

/test all

HaoW30 avatar Mar 28 '25 18:03 HaoW30

/test build

HaoW30 avatar Mar 28 '25 18:03 HaoW30

/retest

bb7133 avatar Apr 04 '25 20:04 bb7133