community icon indicating copy to clipboard operation
community copied to clipboard

Update TiDB team membership and reviewer lists

Open wuhuizuo opened this issue 3 months ago • 8 comments

This pull request updates the TiDB team membership configuration to reflect current roles and responsibilities. The main changes involve moving several contributors between the maintainers, committers, and reviewers lists in the teams/tidb/membership.json file due to reasons such as resignation, job changes, etc. Ensuring that team permissions are up to date to better control the integration quality of the repository's code.

Membership updates:

  • Several individuals were remove from the maintainers and committers to the reviewers list, reflecting a reorganization of team roles. [1] [2]

wuhuizuo avatar Sep 26 '25 03:09 wuhuizuo

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign tiancaiamao for approval. For more information see the Code Review Process. Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Sep 26 '25 03:09 ti-chi-bot[bot]

/hold

wuhuizuo avatar Sep 26 '25 04:09 wuhuizuo

[LGTM Timeline notifier]

Timeline:

  • 2025-09-26 14:18:31.930674567 +0000 UTC m=+625522.001168250: :heavy_multiplication_x::repeat: reset by lance6716.

ti-chi-bot[bot] avatar Sep 26 '25 14:09 ti-chi-bot[bot]

If you are concerned about the code security in the company's software repository, the code owner mechanism should be sufficient to ensure that company employees who are more familiar with the development context can review the code. This community PR is unnecessary.

lance6716 avatar Sep 26 '25 14:09 lance6716

resignation, job changes

We do not nominate reviewers/committers because "they have some jobs".

I think it's better to add the 'inactive roles' when those reviewers/committers do not participate in TiDB community for a long time.

bb7133 avatar Sep 26 '25 17:09 bb7133

According to the governance rules of teams: https://github.com/pingcap/community/tree/master/teams.

If you want to remove a maintainer, please initiate a vote. Moreover, since this time involves many people being changed, I request initiating a ToC vote for discussion and decision-making.

winkyao avatar Sep 27 '25 07:09 winkyao

/assign Benjamin2037

wuhuizuo avatar Sep 28 '25 03:09 wuhuizuo

This doesn’t seem like a proper community initiative, as long as we are still a community. Retiring committers or maintainers should go through a voting process, not just a random PR.

If the concern is about code privileges, we should investigate what went wrong with the current privilege management mechanism and fix it, rather than banning someone for making so-called “trouble”.

zanmato1984 avatar Oct 24 '25 19:10 zanmato1984