Simone Basso

Si, la cosa che secondo me confonde nell'aver fatto il merge in master delle modifiche e' che uno legge la versione stabile della costituzione come se la modifica fosse gia'...

> Si, la cosa che secondo me confonde ... Ah, no, mi correggo: adesso ho capito come e' stato impostato il repository, cioe' con le due versioni della costituzione in...

Thanks for the quick first round of review! :-)

Okay, @sergeyfrolov, I've gone through the comments, and it seems to me the bottom line here is that there is an opportunity for refactoring to avoid side effects, the need...

@max-b thanks for asking! I think I am unlikely to have time anytime soon because with OONI we choose in the end to use another approach to solve this problem...

Trying to address this in #929 I've ended up refactoring significantly the parser. For this reason I am moving this issue from release-0.3.0 (stable) to release-0.4.0 (master).

I think we should delay this, as it should go hand in hand with changes in `#1345

I guess the proper way to fix this consists of making sure that the log line is UTF-8 and otherwise convert the line to base64 such that it's for sure...

_Voilà_: ``` --- ALL.sorted 2019-03-20 16:18:37.000000000 +0100 +++ STUCK.sorted 2019-03-20 16:18:48.000000000 +0100 @@ -66,7 +66,6 @@ PASS: test/nettests/meek_fronted_requests PASS: test/nettests/multi_ndt PASS: test/nettests/ndt -PASS: test/nettests/runnable PASS: test/nettests/tcp_connect PASS: test/nettests/telegram PASS: test/nettests/utils...

I'm going to do some effort to fix this before MK v0.10.0. If that does not converge, I'll tag v0.10.0 and resume. (This seems to be a relatively low probability...