Luca Bertagna

Results 462 comments of Luca Bertagna

I had never heard of Jinja2, so I had to google it. From what I can tell, it is a way to decorate an existing file with some "programmable" snippets,...

Having `track_avg_cnt: true` by default implies that we need to accumulate and write to file a few more fields. While the number of extra fields may not be remarkable, for...

I'm a bit reluctant to make the ParameterList class case-insensitive. But we could implement a validator routine for the main classes (atm proc and IO, for instance), so that if...

The max snapshots value is not enough to decide whether the previous file is full of not. Granted, it may be a corner case, but if the user has already...

We could simply add something in the rhist file though. E.g., we could store the number of snaps stored (if storage type is defined by max snaps per file), so...

I'm not 100% sure what you are referring to with 0 based vs 1 based. If you are referring to what is printed by the driver ``` Atmosphere step =...

If I follow, you would make all levels indep of each other. For each level, you would have to do 2 parabula integrations, plus potentially add mass from old cells...

Btw, while at it, we might also change the impl of the parabola integration, from containing difference of squares/cubes to use factorized expressions. Not a big deal, probably, but also...

It would be really nice to simply rely on TPLs to provide the correct cmake modules without having to ship user-provided ones. If this is indeed working out of the...

> Looks good. > > Just curios: Is it struggling to find pybind11 in mappy/weaver? It often "just" finds it... On mappy I had to pip install pybind11 and mpi4py,...