scream icon indicating copy to clipboard operation
scream copied to clipboard

set track_avg_cnt: true by default

Open mahf708 opened this issue 1 year ago • 3 comments

          >@AaronDonahue should we maybe turn on avg count tracking automatically for this diag? Or, more in general, for any field that can have a certain extra data set in the header (something like "can_have_invalid_data" or something)?

Yes, I think we would want to do that rather than have users try to figure out why some fields are nan, or otherwise bad values.

Originally posted by @AaronDonahue in https://github.com/E3SM-Project/scream/issues/2916#issuecomment-2251330164

mahf708 avatar Jul 26 '24 02:07 mahf708

Also, note to fix this in cosp: https://github.com/E3SM-Project/scream/blob/a1b89eb8e0db61100e03c9770a18e11ed307c8d4/components/eamxx/src/physics/cosp/eamxx_cosp.cpp#L235-L243

And maybe another issue in cosp: https://github.com/E3SM-Project/E3SM/pull/5495#issuecomment-2251063061

mahf708 avatar Jul 26 '24 02:07 mahf708

@AaronDonahue + @bartgol: moving the discussion here.

Is there any downside of setting the default track_avg_cnt: true for everything? No need to special-case it, just turn it on everywhere?

mahf708 avatar Jul 26 '24 13:07 mahf708

Having track_avg_cnt: true by default implies that we need to accumulate and write to file a few more fields. While the number of extra fields may not be remarkable, for use cases where we split output into many files (like prod runs often do), it may add up to a non negligible amount of extra output. As such, I am inclined to have IO detect whether or not track_avg_cnt should be on, and remove it from the yaml file options.

bartgol avatar Jul 26 '24 18:07 bartgol

Closing this as it is an item in https://github.com/E3SM-Project/scream/issues/2938, so no need for a separate issue.

mahf708 avatar Aug 07 '24 21:08 mahf708