Luca Bertagna

C/C++ files: sexy comment across //-style commented lines

5

Currently, when I try to use the 'sexy' comment style on a piece of code like this ``` // My comment some_code_here; ``` I end up with the following ```...

Suggestion: add intermediate class for sinks logging to a file.

1

I have a piece of code that creates a file sink (either basic or rotating), stored in a `base_sink` pointer. When we have to query the name of the file,...

Homme: Some minor tweaks related to print to screen

5

Namely: - allow `iulog` to be settable if `SCREAM` is defined, rather than hard coded to 6 (stdout); - replaced a couple of print to screen with `write(iulog, *)`; -...

At `zoltan/apfZoltanCallbacks.cc:305` we check that zoltan and metis integers are the same size. Since the check only involves compile time constants, this should be done at config time, rather than...

At line 133, nf-config.cmake.in contains ``` echo "${CMAKE_INSTALL_PREFIX}" ``` However, since the file is configured with the `@ONLY` option, this variable is not expanded in the installed file, causing `nf-config...

This means that, inside cells, we will call the dof mgr method `getElementGIDs` and `getElementLIDs` to get a DOF's node lids/gids. This should get rid of several arrays stored in...

This PR aims at simplifying how we store gids for different DOFs. Right now, we store arrays of the form `(numWs, numCells, numNodes, numDims)`, where `numDIms` is the number of...

Without these properties, when running multiple tests at once, all ranks collapse on the same cores (MPI does not check if other MPI jobs are running, so it usually takes...

cudaCheckError macro

1

This macro seems to be pointless. See its declaration [here](https://github.com/SNLComputation/Albany/blob/d05fa059e07e40b66b7d3aa1e371fae82170f2f3/src/Albany_Macros.hpp#L14). @jewatkins @mcarlson801 do you guys hack this line to define it to something meaningfull in nvcc whenever you need to...

Block discretization design choices

2

This issue is more of an heads up than a real issue. If you take a look at [this page](https://github.com/gahansen/Albany/wiki/Blocked-linear-system) in the Albany wiki, you can see a short summary...