bartekch

Make holidays data internal and exported at the same time

2

This PR Fixes #2166 `generated_holidays` dataset is internal now, so there is no possibility for a user to overwrite data used by `prophet` internal functions. At the same time `export`...

[R] `generated_holidays` should be internal

1

`generated_holidays` dataset is exported as `data`, but at the same time it is used internally. This causes issues while trying to use `prophet` without loading. For instance the following code...

In some cases `hot_to_r` does not convert `logical` type correctly and returns `integer` instead. The following example shows different cases. Returned type is incorrect when `logical` column is paired only...

When there is an output with spinner and somewhere in its reactive dependencies the processing is stopped by `req(..., cancelOutput = TRUE)`, spinner will never disappear. In the following app...

If we call `hideFeedback` or `showFeedback*` with `inputId` of nonexistent element, a JS error is throw like on the screen below.  This is NOT causing any issues in Shiny...

Icon as label in loadingButton

8

Is it possible to provide an icon to appear on `loadingButton` as a label? I've tried this (`shinyFeedback 0.4.0`): ```r library(shiny) library(shinyFeedback) shinyApp( ui = basicPage( useShinyFeedback(), loadingButton( inputId =...

I've noticed that `resetLoadingButton` interferes with `shinyjs` functionalities in two ways: - button is hidden with `shinyjs::hide` -> `resetLoadingButton` shows it, - button is disabled with `shinyjs::disable` -> `resetLoadingButton` enables...

I want to create an `actionButton` with `tippy` inside `insertUI`, unfortunately I can't get it working. I've tried the following approaches, without success. ```r library(shiny) library(tippy) shinyApp( ui = basicPage(...

I bumped into this when investigating #69. When creating `loadingButton` with already existing `inputId`, it is correctly removed from `buttons` array, but it looks like `click` event handlers are accumulated....