prophet icon indicating copy to clipboard operation
prophet copied to clipboard

Make holidays data internal and exported at the same time

Open bartekch opened this issue 2 years ago • 2 comments

This PR Fixes #2166

generated_holidays dataset is internal now, so there is no possibility for a user to overwrite data used by prophet internal functions. At the same time export tag is added, so a user could still use generated_holidays directly after loading prophet.

bartekch avatar May 25 '22 16:05 bartekch

Hi @bartekch!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar May 25 '22 16:05 facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar May 25 '22 18:05 facebook-github-bot