Bartek Szopka

Results 428 comments of Bartek Szopka

Triage: to be verified now that we introduced CSS variables for theming.

Currently nav is not using grid directly, and this change will require it to do so. I don't know what impact it may have. It would be trivial to just...

@lyubomir-popov Aligning logo width to grid is not trivial (without reimplementing the grid), because grid col widths are not static, they are flexible below max width. So unless we implement...

Triage: this was addressed in React already. Likely no need to fix it in current Vanilla CSS codebase. To be taken into consideration while migrating components to new architecture.

This is very high effort. Current Vanilla codebase is likely not going to be able to support icons in any possible colour as this would require generating separate SVG for...

> > Current Vanilla codebase is likely not going to be able to support icons in any possible colour as this would require generating separate SVG for each icon for...

Triage: we definitely need to take it as consideration/requriement for new architecture. For current codebase we need to investigate (timebox 1-2 days max) to see how we could use CSS...

The issue with Percy and iframe has been fixed (https://github.com/canonical/react-components/pull/1145) so rebasing this branch on main should fix this problem here.

@lorumic Not sure if I fully understand. If Modal is a child of a ContextualMenu, why clicking on modal is recognised as clicking outside of ContextualMenu? Overall, I don't think...