Bartek Szopka

Results 428 comments of Bartek Szopka

Triage: this seems high effort and unknown impact. Do we really need this? If we do, consider for new architecture.

@lyubomir-popov Is this still something we would like to do? Maybe as an item for new architecture (and possible revisited grid there)?

The build fails due to undefined variable. Seems that the `$input-border-thickness` that you try to use is defined later in the code. It would have to be moved up. I...

Reimplemented in https://github.com/canonical/vanilla-framework/pull/5389

@lyubomir-popov can you paste links to the pages where it actually happens, there maybe something else going on Nesting does work on Vanilla grid: https://vanillaframework.io/docs/examples/patterns/grid/nested

> this doesn't: ![image](https://private-user-images.githubusercontent.com/2741678/316036083-1d1ea0c5-ab34-407a-9e95-a37bed2bc536.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTExMTU5MDMsIm5iZiI6MTcxMTExNTYwMywicGF0aCI6Ii8yNzQxNjc4LzMxNjAzNjA4My0xZDFlYTBjNS1hYjM0LTQwN2EtOWU5NS1hMzdiZWQyYmM1MzYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDMyMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDAzMjJUMTM1MzIzWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MzhmZDM2OTk1Y2RiMzRkM2Y1YTQ5ZDEyOWRlOTcyNzkxYTc4YzM5MjQ5NjRiMDQyNzIxNmM0ZDYzZTRlZWUzYyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.jmDNNlzQc_dK1SoXvubtp8_jXWcD9nHCGDggaoPLXmI) @lyubomir-popov this doesn't work because there is no col defined for desktop, so it likely assumes 12 column. It needs to define how many columns on...

Grid nesting works as expected, to any level with standard low level grid class names (`row`, etc). With shorthand `row--25-75` nesting works on first level (`row--25-75` > `col` > `row`),...

@lyubomir-popov BTW, by "3 levels of nesting" do you mean, having 3 grids: `row--25-75` > nested `row` > another nested `row` or actually 3 nested grids, 4 in total? `row--25-75`...

Triage: Looks like quite likely grid works as expected (at least in most cases). Adding more nesting functionality is quite high effort to address it now, with relatively low impact...

@lyubomir-popov Any thoughts on this? Having background on cells doesn't align well with the borders between them in mobile view.