vanilla-framework icon indicating copy to clipboard operation
vanilla-framework copied to clipboard

Update nav column alignment so that the loog/bubble part takes up 3 columns on desktop

Open lyubomir-popov opened this issue 2 years ago • 3 comments

Like so image

lyubomir-popov avatar Jun 12 '23 16:06 lyubomir-popov

Currently nav is not using grid directly, and this change will require it to do so. I don't know what impact it may have.

It would be trivial to just adjust the static value to match the grid, but obviously this won't work on smaller screens when grid is responsive.

I'd rather address it later as part of component UI refresh of navigation, not as part of initial 4.0.

bartaz avatar Jun 13 '23 12:06 bartaz

I would be fine if we simply adjust the current hardcoded logo area width to match the grid

lyubomir-popov avatar Jun 13 '23 14:06 lyubomir-popov

@lyubomir-popov Aligning logo width to grid is not trivial (without reimplementing the grid), because grid col widths are not static, they are flexible below max width. So unless we implement the grid there they will misalign on some screen widths.

If we want to implement this alignment, and make it default, I guess we should just properly start using grid in top nav? This may also help (or at least affect) the alignment of navigation items with the content of the page that we have issues for.

So is this 25/75 split in top navigation something we want to have as a default everywhere eventually?

bartaz avatar Nov 23 '23 08:11 bartaz

Already fixed.

bartaz avatar Sep 24 '24 08:09 bartaz

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/WD-15232.

This message was autogenerated